openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Car Port: 2023 Honda Accord

Open vanillagorillaa opened this issue 10 months ago • 2 comments

  • [ ] added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • [x] test route added to routes.py
  • [x] route with openpilot: 4df2d9d0197e20e3/0000000c--a564a3f944
  • [x] route with stock system: 4df2d9d0197e20e3/0000000e--54aa88db6f
  • [x] car harness used (if comma doesn't sell it, put N/A): Bosch C

vanillagorillaa avatar Apr 17 '24 01:04 vanillagorillaa

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Apr 17 '24 01:04 github-actions[bot]

@vanillagorillaa any reason this is still in draft?

jyoung8607 avatar Jul 03 '24 16:07 jyoung8607

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

sshane avatar Aug 20 '24 06:08 sshane