openpilot
openpilot copied to clipboard
commaai
GM: Add BSM from Powertrain Bus
Using fingerprint info, the message is there on most upstream GM car’s except Volts, Escalades ESV, Equinox, and Holden Astra.
Confirmed working on: Bolt Silverado XT4
Prerequisites: https://github.com/commaai/opendbc/pull/993
GMC 1500(fingerprints as a Silverado) route: dc7716b32bf25574|2023-12-27--21-15-59--0
Bolt EUV route: 3140e1c6195c880e|2023-12-27--21-15-14--0
https://github.com/commaai/openpilot/assets/63013446/b554b0a6-dff7-4969-84ad-20b2c3a35a02
On the 2018 Arcadia, the BSM signal is only 1 when the BSM light is on and the turn signal is on.
Nice find!
On the 2018 Arcadia, the BSM signal is only 1 when the BSM light is on and the turn signal is on.
Maybe another bit tells us this?
Nice find!
On the 2018 Arcadia, the BSM signal is only 1 when the BSM light is on and the turn signal is on.
Maybe another bit tells us this?
@sshane None in that message, there are times where those are the only bits that change.
Looks like the original signals are
SG_ RightLaneChangeThreat : 7|1@0+ (1,0) [0|1] "" XXX
SG_ LeftLaneChangeThreat : 6|1@0+ (1,0) [0|1] "" XXX
so this makes sense. Newer cars likely just changed the behavior slightly to always show this
There's also some speed signals for the BSMs in there, but no distance. Can you add a comment to the DBC explaining it can be only when the blinker is on, for some cars?
It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
There's also some speed signals for the BSMs in there, but no distance. Can you add a comment to the DBC explaining it can be only when the blinker is on, for some cars?
On the Acadia, the Blind Spot warning light on the mirror lights up when a vehicle is in your blindspot and the warning light flashes if the turn signal is turned on while a vehicle is there. GM calls this the Side Blind Zone Alert system (SBZA) and is included in the Lane Change Alert system (LCA).
@Verylukyguy if you want to help us find the bit that has the BSM indicator at all times, you'll need to go get a route where you turn the turn signal on in the direction that it shows the BSM alert for as long as it does (so we can cross reference it with Cabana). This might confuse some drivers around you though
@Verylukyguy if you want to help us find the bit that has the BSM indicator at all times, you'll need to go get a route where you turn the turn signal on in the direction that it shows the BSM alert for as long as it does (so we can cross reference it with Cabana). This might confuse some drivers around you though
I definitely want to help improve the overall OpenPilot experience whenever I can. I'll make a route today and let you guys know when it ready.
Right Side: df51b2195de66a9b|2024-01-24--17-19-57--8 Left Side: df51b2195de66a9b|2024-01-24--18-01-06--1
I can't find it from that, we'll need at least 10 total seconds throughout a very short route to filter out the noise. Remember, whenever the light is on, you need to perform some action, and whenever the light is off, you should stop that action. Try to match the light very closely. Maybe put the car in L or N gear so you don't have to use the blinkers?
Also needs to only be for one light per action, so:
left bsm light goes on -> put car in low left bsm light goes off -> put car back in drive
a few cases for multiple seconds and we should be able to find it, if it exists
Updated BCMBlindSpotMonitors to BCMBlindSpotMonitor to match merged opendbc code.
Try this route: df51b2195de66a9b|2024-01-26--18-54-15--0
Thanks, unfortunately I still didn't find it. It may only be on another bus on your car. Besides the original signal name is something to the effect of 'Lane Change Threat', so it only being 1 when the turn signal is on doesn't seem crazy.