openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

VW MQB: Add FW for 2023 Karoq

Open Saber422 opened this issue 1 year ago • 2 comments

route name:9c3d97394a78e872|2023-12-12--14-39-47--6

Saber422 avatar Dec 13 '23 09:12 Saber422

@jyoung8607 this doesn't pass our fingerprint checker bot because a lot of the FW returned comes from Hyundai queries which aren't used in VW fingerprinting. Are you aware of cases like this? Looks like not all routes are like this though. I see some response pendings in the logs, let me check to make sure there's not a bug with that

image

sshane avatar Jan 22 '24 09:01 sshane

Can't say if it's universal, but I can say it's extremely common for engine and transmission firmware. I see it (and ignore it) all the time when adding fingerprints.

Since this PR came from @Saber422, who is an expert user, it's possible we're onroad and driving via fingerprintSource: fixed and therefore the UDS brand-query filtering logic may not have been run. I don't have permissions to this particular device to look.

jyoung8607 avatar Jan 22 '24 18:01 jyoung8607

Sorry for late replying. I ask the owner to upload logs. You can check new route now. 9c3d97394a78e872|2024-02-15--15-51-54--0 @jyoung8607 The owner add your id, you can also double check the car params to see if it's all right.

Saber422 avatar Feb 16 '24 12:02 Saber422

Looks like there's a lot of UDS communication going on with at least the engine not by us, throughout the first segment of that route. Is there an OBD debugging dongle plugged in?

sshane avatar Feb 20 '24 23:02 sshane

The owner used OBD device, Lufi XS 3rd, so I ask him unplug it and make two routes. S__176095242

9c3d97394a78e872/2024-02-29--17-08-52/0 9c3d97394a78e872/2024-02-29--14-30-55/0

Saber422 avatar Mar 01 '24 14:03 Saber422

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Mar 06 '24 03:03 github-actions[bot]