openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Honda : 2023 Pilot Car Port

Open vanillagorillaa opened this issue 1 year ago • 6 comments

Checklist

  • [ ] added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • [X] test route added to routes.py
  • [x] route with openpilot: f9c43864cf057d05|2024-01-15--23-01-20
  • [X] route with stock system: f9c43864cf057d05|2024-01-13--14-08-31
  • [X] Harness : Bosch C

First port for a new CAN-FD Honda

DBC Notes: Using accord DBC, these messages are missing. Will have to check if they are on different ID's now 229 BOSCH_SUPPLEMENTAL_1 232 BRAKE_HOLD 316 GAS_PEDAL 490 VEHICLE_DYNAMICS 545 XXX_16 597 ROUGH_WHEEL_SPEED 892 CRUISE_PARAMS 927 RADAR_HUD 1029 DOOR_STATUS 13274 LKAS_HUD_A 13275 LKAS_HUD_B

vanillagorillaa avatar Oct 25 '23 04:10 vanillagorillaa

This PR has had no activity for 30 days. It will be automatically closed in 7 days if there is no activity.

github-actions[bot] avatar Dec 15 '23 01:12 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Dec 23 '23 01:12 github-actions[bot]

0x33D, LKAS_HUD, on this platform is 8 bytes, not 5 like previous Bosch vehicles

In a stock route seeing new data on this signal, SG_ NEW_SIGNAL_1 : 37|3@0+ (1,0) [0|7] "" XXX

Edit- looks like the 2022 Civic LKAS_HUD is also 8 bytes, and has this same signal already in the DBC (although it's defined as 2 bits and not 3)

vanillagorillaa avatar Jan 13 '24 21:01 vanillagorillaa

It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template.

github-actions[bot] avatar Jan 17 '24 03:01 github-actions[bot]

First Honda that doesn't require the OBD port! 🎉

sshane avatar Jan 26 '24 05:01 sshane

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Feb 29 '24 17:02 github-actions[bot]