openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Toyota: parse radar for radar-ACC TSS-P cars

Open Smartype opened this issue 3 years ago • 3 comments

Test route: https://connect.comma.ai/2f37c007683e85ba/1674339187978/1674340344411

Smartype avatar Oct 19 '22 04:10 Smartype

Is PR just to add radar parsing support? No longcontrol is in the works? If so, it sounds like when we crack disabling an ECU, we can get longcontrol for these cars (but radar will likely not be publishing any track data, so not sure if this is worth it)

sshane avatar Oct 19 '22 08:10 sshane

I have a hardware similar to sdsu. I was told to separate the radar support and long control stuffs.

This is the original PR.

https://github.com/commaai/openpilot/pull/24695

Is PR just to add radar parsing support? No longcontrol is in the works? If so, it sounds like when we crack disabling an ECU, we can get longcontrol for these cars (but radar will likely not be publishing any track data, so not sure if this is worth it)

Smartype avatar Oct 19 '22 08:10 Smartype

@sshane can we get this merged? If not, what else shall I do? Thanks!

Smartype avatar Jan 22 '23 03:01 Smartype

Is someone able to push this through or give some feedback? We have been patiently waiting.

williefeb19 avatar Feb 27 '23 14:02 williefeb19

Can you rebase on master and clean up the PR?

sshane avatar Mar 02 '23 00:03 sshane

@sshane on my private fork, I added a vAbs to RadarPoint. So that we can keep the changes in Toyota only.

vAbs @7 :Float32 = nan; # m/s

But this requires cereal updates. Which one you prefer?

Smartype avatar Mar 02 '23 07:03 Smartype

@sshane This is the PR for cereal

https://github.com/commaai/cereal/pull/414

Smartype avatar Mar 02 '23 07:03 Smartype

I'm fine with passing in v_ego for now. Did you accidentally close the PR?

sshane avatar Mar 03 '23 05:03 sshane

I'm fine with passing in v_ego for now. Did you accidentally close the PR?

This might be caused by force pushing... I have created a new PR, but this one depends on cereal PR

https://github.com/commaai/openpilot/pull/27486

If you can merge the cereal PR, I can ask someone upload a route based on my branch.

Smartype avatar Mar 03 '23 06:03 Smartype