openpilot
openpilot copied to clipboard
Toyota: parse radar for radar-ACC TSS-P cars
Test route: https://connect.comma.ai/2f37c007683e85ba/1674339187978/1674340344411
Is PR just to add radar parsing support? No longcontrol is in the works? If so, it sounds like when we crack disabling an ECU, we can get longcontrol for these cars (but radar will likely not be publishing any track data, so not sure if this is worth it)
I have a hardware similar to sdsu. I was told to separate the radar support and long control stuffs.
This is the original PR.
https://github.com/commaai/openpilot/pull/24695
Is PR just to add radar parsing support? No longcontrol is in the works? If so, it sounds like when we crack disabling an ECU, we can get longcontrol for these cars (but radar will likely not be publishing any track data, so not sure if this is worth it)
@sshane can we get this merged? If not, what else shall I do? Thanks!
Is someone able to push this through or give some feedback? We have been patiently waiting.
Can you rebase on master and clean up the PR?
@sshane on my private fork, I added a vAbs to RadarPoint. So that we can keep the changes in Toyota only.
vAbs @7 :Float32 = nan; # m/s
But this requires cereal updates. Which one you prefer?
@sshane This is the PR for cereal
https://github.com/commaai/cereal/pull/414
I'm fine with passing in v_ego for now. Did you accidentally close the PR?
I'm fine with passing in v_ego for now. Did you accidentally close the PR?
This might be caused by force pushing... I have created a new PR, but this one depends on cereal PR
https://github.com/commaai/openpilot/pull/27486
If you can merge the cereal PR, I can ask someone upload a route based on my branch.