openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Published 20 hours ago • verified publisher icon commaai

pcmCruise GM: auto-resume

Open sshane opened this issue 3 years ago • 4 comments

sshane avatar Aug 23 '22 04:08 sshane

image Okey dokey!

twilsonco avatar Aug 23 '22 04:08 twilsonco

Installing. I'll test in the morning. Looks like I'll be pressing the resume button in different scenarios. Stopped, engaging, increase set speed, resume behind lead?

twilsonco avatar Aug 23 '22 06:08 twilsonco

This is only set up to work on the new camera-ACC stock longitudinal GMs right now, it's to press the resume button for the user to resume.

sshane avatar Aug 23 '22 07:08 sshane

Ack! That explains all the CAMERA I was seeing!

twilsonco avatar Aug 23 '22 12:08 twilsonco

I think the camera must manage the cruise state here (which makes sense why we need to send cancel to the camera), not the PT side, so we need to spam resume on the camera bus. Or modules on both sides could be listening to button presses, will need to verify

sshane avatar Sep 02 '22 20:09 sshane

Will re-open when working

sshane avatar Oct 03 '22 18:10 sshane

So there appears to be some redundancy here. If you block the physical buttons to the camera, neither of the two actions separately cause the car to resume: pressing the resume button physically or sending the resume button to the camera. You need both sides of the relay to see the buttons being pressed in order to go

sshane avatar Oct 04 '22 06:10 sshane