xmr-btc-swap icon indicating copy to clipboard operation
xmr-btc-swap copied to clipboard

Published 20 hours ago • verified publisher icon comit-network

[1.0 XMR] Provide better feedback when cancel/refund transaction publish fails by parsing electrum error

Open thomaseizinger opened this issue 3 years ago • 15 comments

As discovered in https://github.com/comit-network/xmr-btc-swap/issues/674, users may try to refund a swap even though that is no longer possible because Alice already punished.

We should catch this case by parsing the error message returned from electrum and display something more informative to the user.

Also, we need to advance the internal state to correctly reflect what happened on the blockchain, otherwise swap list returns misleading information.

thomaseizinger avatar Aug 24 '21 23:08 thomaseizinger

Duplicate of https://github.com/comit-network/xmr-btc-swap/issues/455

da-kami avatar Aug 25 '21 22:08 da-kami

We use bounties to incentivize development and reward contributors. All issues available for a bounty have the Bounty 💰 label.

To receive the bounty of this issue, you agree to these conditions:

  • Your changes must follow the styling guidelines.
  • Bounties will be set and awarded at discretion of @binarybaron . The issues eligible for a bounty are labelled 'Bounty 💰' and have the amount of the bounty specified in the title in this form: [1 XMR].
  • An issue is considered resolved when the patch(es) proposed by the contributor is/are merged in the appropriate repository according to terms of the issue.
  • The first person who resolves an issue in its entirety will receive the entire amount of the bounty.
  • If the issue is resolved collaboratively by more than one person, the reward will be distributed among the contributors
  • Let the Maintainers know if you intend to work on a bounty, so that the issue can be assigned to you. Being assigned to an issue doesn't make that issue resolvable only by the assignee. It's meant to avoid duplication of efforts and not to discourage collective works.
  • After the issue is resolved, contact @binarybaron and claim your bounty (remember to provide them with a Monero address).

binarybaron avatar Aug 04 '22 13:08 binarybaron

@delta1 Would you be interested in taking this on?

binarybaron avatar Aug 04 '22 13:08 binarybaron

Yes definitely! Will pick it up after getting #1081 fixed and released for the hard fork

delta1 avatar Aug 04 '22 13:08 delta1

I did start working on this a bit. I'll publish my WIP branch later, if @delta1 or anyone else wants to pick up from where I left

binarybaron avatar Aug 10 '22 13:08 binarybaron

Yeah was taking a look! Happy to pick it up - please share your branch name

delta1 avatar Aug 10 '22 13:08 delta1

https://github.com/comit-network/xmr-btc-swap/compare/master...binarybaron:xmr-btc-swap:detect-timelocks-manual-refund

binarybaron avatar Aug 10 '22 15:08 binarybaron

Increased bounty to 0.5 XMR! @delta1 @lescuer97

binarybaron avatar Sep 12 '22 14:09 binarybaron

Nice! Picking this back up tomorrow 👌

delta1 avatar Sep 12 '22 14:09 delta1

Any updates? Have you had time to take a look at this again?

binarybaron avatar Sep 27 '22 21:09 binarybaron

No updates, sorry have been dealing with personal issues so if somebody else could pick it up that’s totally fine. Otherwise I can get back to it in a couple of weeks.

delta1 avatar Sep 28 '22 05:09 delta1

I'm increasing the bounty to 1 XMR because I believe this will provide some major benefits in terms of usability! @lescuer97 @delta1 @all

binarybaron avatar Jun 06 '23 11:06 binarybaron

@binarybaron I'm increasing the bounty to 1 XMR because I believe this will provide some major benefits in terms of usability!

I'm interested, can I try to implement this?

thenhnn avatar Mar 06 '24 07:03 thenhnn

sure @thenhnn go ahead

delta1 avatar Mar 06 '24 09:03 delta1

@delta1 sure @thenhnn go ahead

Please check #1571

thenhnn avatar Mar 06 '24 13:03 thenhnn