xmr-btc-swap icon indicating copy to clipboard operation
xmr-btc-swap copied to clipboard

document use of asb export-bitcoin-wallet

Open icy-ux opened this issue 2 years ago • 8 comments

Add to the asb document @delta1's text on exporting the Bitcoin wallet descriptor and importing the descriptor into Sparrow Wallet. Addresses #878

TODO: maybe it would make sense to add the images to Git, instead of linking to files on Github?

icy-ux avatar Jan 12 '23 17:01 icy-ux

Looks like one integration test fails, but it's not my fault

icy-ux avatar Jan 12 '23 18:01 icy-ux

Looks like one integration test fails, but it's not my fault

It's a timeout, happens from time to time

binarybaron avatar Jan 13 '23 08:01 binarybaron

These bulletpoints are formatted in a very weird way. Please use normal bulletpoints.

Fixed. The formatting was directly copied from @delta1's original text, so I assumed it was formatted according the project style.

icy-ux avatar Jan 13 '23 09:01 icy-ux

Thanks @icy-ux, I think this could be written better and not need the images, and I'd also like to figure out how to import it into the bdk cli correctly.

delta1 avatar Jan 13 '23 14:01 delta1

These bulletpoints are formatted in a very weird way. Please use normal bulletpoints.

Fixed. The formatting was directly copied from @delta1's original text, so I assumed it was formatted according the project style.

Yeah true, I see why you did that. Really no offense intended. Thank you alot for the PR, we really need to improve the documentation overall.

binarybaron avatar Jan 13 '23 15:01 binarybaron

@icy-ux please run dprint fmt and then I’m happy for this to go in, it can always be updated later.

delta1 avatar Jan 13 '23 19:01 delta1

@icy-ux please run dprint fmt and then I’m happy for this to go in, it can always be updated later.

Done.

Unfortunately the backticks in my commit message were cut out along the way, so it's not the best commit message in the world.

icy-ux avatar Jan 14 '23 08:01 icy-ux

Thanks! No problem, please squash your commits into 1, make sure it’s GPG signed, force push and then we’ll get this merged.

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

delta1 avatar Jan 14 '23 08:01 delta1

+1 to adding the images to version control, in the docs folder

ikmckenz avatar Apr 30 '24 04:04 ikmckenz

@ikmckenz @icy-ux please add a commit including the images and updating the paths in the md file

delta1 avatar Apr 30 '24 07:04 delta1

@delta1 done, should be ready to merge

icy-ux avatar May 18 '24 10:05 icy-ux