ComfyUI
ComfyUI copied to clipboard
comfyanonymous
Allow primitives to connect to reroutes with type
- Added a check so that reroute nodes won't connect widget inputs with the same type but different configs (e.g. seed and steps).
- The widget property of widget inputs is distributed among every reroute node in the reroute chain, allowing primitives to connect.
I had to prevent disconnecting reroutes to outputs with the wildcard type so that they won't disconnect primitive nodes on startup when primitives don't have an output type yet. May have unintended consequences.
I also have the display type to refer to the output type if the input type is a wildcard. Primitives may not have a specific type yet while loading a graph and the wildcard type would have been adopted by the reroute nodes.
Testers appreciated.
Hi Is this what prevents me connecting a primitive to a seed in the sampler node via a reroute?
Looks like it also stops you putting reroute on model/lora primitives too :(
Looks like it also stops you putting reroute on model/lora primitives too :(
Sorry, I didn’t have notifications from this PR. I am leaving this on the back burner since it doesn’t seem like there’s much demand for this capability.
It has been mentioned here? https://www.reddit.com/r/comfyui/comments/14kcx27/primitive_to_reroute/
I find this particularly problematic with the LORA's. If I want a primitive with a dropdown for LORA models elsewhere (eg. with prompts and other inputs all grouped together) then I cannot reroute the primitives and the wiring gets rather messy!
Yeah that must be tedious. I will see what I can do once I’m finished with things that interest me more.
Don't mind me. Just adding myself to the pile of people interested by that.
Has anyone tried using the current changes I made? I don’t want to add bugs that I’m not aware of.
Considering this is a merge conflict marked as a draft since last year, I'll close this - if it's still relevant, please rebuild against current code.
