ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

spandrel python package pulls nvidia dependencies even on AMD systems, and since it's in requirements.txt it gets auto installed during updates

Open ikcikoR opened this issue 5 months ago • 1 comments

Expected Behavior

Updating ComfyUI does not install nvidia dependencies on AMD systems

Actual Behavior

Updating ComfyUI installs nvidia dependencies on AMD systems

Steps to Reproduce

source venv/bin/activate pip install -r requirements.txt

Debug Logs

Don't have them anymore and I don't want to install those deps again but out of other things: 

nccl-cu12 nvidia-cuda-cupti-cu12 nvidia-cuda-nvrtc-cu12 nvidia-cuda-runtime-cu12 nvidia-cudnn-cu12 nvidia-cufft-cu12 nvidia-curand-cu12 nvidia-cusolver-cu12 nvidia-cusparse-cu12 nvidia-nccl-cu12 nvidia-nvjitlink-cu12 nvidia-nvtx-cu12

get installed

Other

I suggest not putting spandrel as a default dependency until it doesn't pull nvidia deps on all platforms

ikcikoR avatar Sep 10 '24 21:09 ikcikoR