ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Add Batch Size Argument for EmptyLatentAudio and WAV File Format Option for SaveAudio

Open lobster-mane opened this issue 1 year ago • 2 comments

This merge request introduces two new features for the audio tools:

  1. Batch Size Argument for EmptyLatentAudio:
    This feature allows users to specify the batch size when creating empty latent audio with the EmptyLatentAudio node. Can be used for making one-shot (drum) samples.

  2. WAV File Format Option for SaveAudio:
    A new option to save audio files in WAV format has been added to the SaveAudio node. This change enables users to save audio files in the widely used WAV format, making integration with other audio tools easier, instead of relying only on FLAC.

Changes

  • Added a batch_size argument to the EmptyLatentAudio node.
  • Updated the SaveAudio node to support saving audio files in WAV format.

Benefits

  • Improved flexibility and scalability:
    The batch size argument allows users to create larger batch sizes to be used to create one-shot samples or more variations.

  • Broader file format support:
    The WAV format is commonly used in many audio processing workflows and has better support in DAWs. Adding support for it helps increase compatibility with various applications and use cases.

Testing

  • Both features have been tested to ensure they work as expected, and no existing functionality was affected.

Please review and let me know if any additional changes are needed. Thank you!

lobster-mane avatar Aug 31 '24 20:08 lobster-mane

Adding batch size is good but I think the wav saving should be a different node because different file formats can have different options.

comfyanonymous avatar Sep 04 '24 06:09 comfyanonymous

Could you please separate the two parts of this PR into two separate PRs?

mcmonkey4eva avatar Sep 09 '24 06:09 mcmonkey4eva