ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Update example_node.py.example

Open 311-code opened this issue 1 year ago • 2 comments

Huggingface-hub telemetry apparantly extracts example docstrings for telemetry purposes. Check hub.py and hf_api.py in .cache.

If a user has not opted out of hf telemetry this could potentially expose sensitive data if template is widely used. Commented out all occurences of """ as better safe then sorry. See a user's post here on it

I checked myself and hub.py does seems to extract a lot of information before sending via the hub.py and hf_api.py I think covers the doctring telemetry info. Def send_telemetry only only filters _ and None values

Edit: Hopefully this won't prevent descriptive info from becoming available. I just think should be cautious if any external tools or integrations rely on those docstrings for any specific purpose.

311-code avatar Aug 18 '24 04:08 311-code

If you can show me actual proof that it's sending telemetry by default I'll do even better and strip out all huggingface related dependencies from ComfyUI.

comfyanonymous avatar Aug 18 '24 05:08 comfyanonymous

i have some weird symlink shenanigans going on with one of the TTS nodes. it does that with the models used for that particular one. The Whisper TTS one. https://github.com/if-ai/ComfyUI-IF_AI_WishperSpeechNode Tried to disable it in Python and find the models and put them in the appropriate folders, but i gave up on it. Why can't i just download the models with the manager or do it manually like usual? It's weird.

Hellrunner2k avatar Aug 19 '24 04:08 Hellrunner2k

@comfyanonymous HF Hub in particular at least sends telemetry, some other libs do, in SwarmUI I inject these env vars to block telemetry for not just swarm's comfy stuff but also some common custom node imported libs even:

https://github.com/mcmonkeyprojects/SwarmUI/blob/630bebeae7819a4c33cfb439dcb781708e0c944a/src/Utils/PythonLaunchHelper.cs#L31-L33

        start.Environment["YOLO_OFFLINE"] = "true"; // Tell ultralytics not to attempt telemetry
        start.Environment["DISABLE_TELEMETRY"] = "true"; // Tell HF no telemetry
        start.Environment["DO_NOT_TRACK"] = "true"; // Generic telemetry disable

It would make sense to add similar to ComfyUI itself's default launching imo.

I had a user monitoring network traffic out of the swarm comfy install and they confirmed after this it from occasional pings to silence.


That said the PR itself here is a bit silly, commenting out docstrings to reduce telemetry data is not the way to do that, and docstrings are nice to have

mcmonkey4eva avatar Aug 21 '24 01:08 mcmonkey4eva