ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Published 20 hours ago • verified publisher icon comfyanonymous

Some minor code tweaks

Open jslegers opened this issue 1 year ago • 1 comments
trafficstars

global folder_names_and_paths is missing in get_folder_paths

jslegers avatar Aug 10 '24 22:08 jslegers

I also cleaned up some helper functions that either weren't used at all or are pretty useless.

jslegers avatar Aug 11 '24 23:08 jslegers

oh, right, I can just edit PRs to make minor adjustments, nice

mcmonkey4eva avatar Sep 16 '24 03:09 mcmonkey4eva

(Automated Bot Message) CI Tests are running, you can view the results at https://ci.comfy.org/?branch=4303%2Fmerge

github-actions[bot] avatar Sep 16 '24 15:09 github-actions[bot]

Comfy looked this over and did some testing, and found a bug that didn't surface in my own testing and attempts to cleanup (openaimodel line 649 edit is wrong), and after some discussion we reached the conclusion that this type of broad large alteration should not come from an external PR, or if you do send a PR it should be one file at a time, and very thoroughly validated.

mcmonkey4eva avatar Sep 17 '24 17:09 mcmonkey4eva