ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Support Flux DoRA from SimpleTuner

Open markuryy opened this issue 1 year ago • 3 comments

After training a DoRA for Flux.1 dev via SimpleTuner, loading the DoRA in ComfyUI using the LoraLoaderModelOnly node results in a number of "lora key not loaded" messages. I chose this node because the text encoders were not fine tuned I believe.

For testing I have uploaded the safetensors of the DoRA I am trying to load here

model weight dtype torch.float8_e4m3fn, manual cast: torch.bfloat16
model_type FLUX
lora key not loaded: transformer.single_transformer_blocks.0.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.0.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.0.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.1.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.1.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.1.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.10.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.10.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.10.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.11.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.11.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.11.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.12.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.12.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.12.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.13.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.13.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.13.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.14.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.14.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.14.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.15.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.15.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.15.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.16.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.16.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.16.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.17.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.17.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.17.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.18.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.18.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.18.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.19.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.19.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.19.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.2.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.2.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.2.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.20.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.20.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.20.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.21.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.21.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.21.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.22.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.22.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.22.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.23.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.23.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.23.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.24.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.24.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.24.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.25.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.25.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.25.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.26.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.26.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.26.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.27.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.27.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.27.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.28.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.28.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.28.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.29.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.29.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.29.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.3.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.3.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.3.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.30.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.30.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.30.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.31.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.31.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.31.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.32.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.32.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.32.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.33.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.33.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.33.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.34.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.34.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.34.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.35.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.35.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.35.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.36.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.36.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.36.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.37.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.37.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.37.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.4.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.4.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.4.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.5.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.5.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.5.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.6.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.6.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.6.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.7.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.7.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.7.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.8.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.8.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.8.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.9.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.9.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.single_transformer_blocks.9.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.0.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.0.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.0.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.0.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.1.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.1.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.1.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.1.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.10.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.10.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.10.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.10.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.11.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.11.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.11.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.11.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.12.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.12.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.12.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.12.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.13.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.13.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.13.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.13.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.14.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.14.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.14.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.14.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.15.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.15.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.15.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.15.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.16.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.16.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.16.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.16.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.17.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.17.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.17.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.17.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.18.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.18.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.18.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.18.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.2.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.2.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.2.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.2.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.3.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.3.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.3.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.3.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.4.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.4.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.4.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.4.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.5.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.5.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.5.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.5.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.6.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.6.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.6.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.6.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.7.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.7.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.7.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.7.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.8.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.8.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.8.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.8.attn.to_v.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.9.attn.to_k.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.9.attn.to_out.0.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.9.attn.to_q.lora_magnitude_vector
lora key not loaded: transformer.transformer_blocks.9.attn.to_v.lora_magnitude_vector
Model doesn't have a device attribute.
clip missing: ['text_projection.weight']
Requested to load FluxClipModel_
Loading 1 new model
Requested to load Flux
Loading 1 new model

Thank you for looking into this (again)

markuryy avatar Aug 07 '24 14:08 markuryy

I can confirm that I am experiencing the same thing on my end.

stepfunction83 avatar Aug 14 '24 23:08 stepfunction83

@comfyanonymous i can confirm this is the key structure we will be sticking with and it is safe to support this one.

bghira avatar Aug 15 '24 15:08 bghira

Can someone give me a dora of this format that is confirmed working with an example image?

comfyanonymous avatar Aug 18 '24 07:08 comfyanonymous

This issue is being marked stale because it has not had any activity for 30 days. Reply below within 7 days if your issue still isn't solved, and it will be left open. Otherwise, the issue will be closed automatically.

github-actions[bot] avatar Mar 13 '25 11:03 github-actions[bot]

it's likely still an issue, but i assumed @markuryy had a demo model to share. i can make one if it's still wanted @comfyanonymous

bghira avatar Apr 01 '25 12:04 bghira

I remember fixing some diffusers dora issue for flux but I don't remember if I actually implemented this specific format or not.

comfyanonymous avatar Apr 01 '25 17:04 comfyanonymous

it'd be the same one, i'm doing state dict conversions so it's not actually vanilla PEFT key layouts, those do not work in Diffusers.

bghira avatar Apr 01 '25 18:04 bghira