ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Option clarity for SetUnionControlNetType node: deblur

Open RandomGitUser321 opened this issue 1 year ago • 2 comments

Based on the creator's example: https://github.com/xinsir6/ControlNetPlus/blob/main/promax/controlnet_union_test_tile_deblur.py

It uses the same option as tile.

To avoid bloating the menu, I didn't change repaint to be repaint/inpaint/outpaint, but they all use option 7

RandomGitUser321 avatar Jul 17 '24 02:07 RandomGitUser321

@comfyanonymous It's a minor text value change. PTAL

huchenlei avatar Jul 18 '24 16:07 huchenlei

I've actually rethought it a little and it should likely have some extra separate tags like "deblur(promax), inpainting(promax), outpainting(promax)" and so on. Not everyone will use the promax version of the model. They might use the same {x,x,x,x,x,x,x} types of values, but it would help avoid confusion at the use level and would avoid making the list have a bunch of wide and bloated options.

EDIT: Something along the lines of this

    "tile/super_res/variation(promax)": 6,
    "deblur(promax)": 6,
    "in/outpaint(promax)": 7,

RandomGitUser321 avatar Jul 18 '24 18:07 RandomGitUser321