ComfyUI Please combine the `BasicScheduler` and `AlignYourStepsScheduler` nodes

I really see no point in keeping them separate other than AYS not having a model input, but can't that just be ignored, when one of AYS schedulers is selected? I would like to make a group node for sampling with some additional functionality and the SamplerCustom family of nodes has been very useful to that end, however with the BasicScheduler not having access to AYS I have to keep two versions of the group node and keep reconnecting everything every time I want to switch to/away from AYS.

May 27 '24 05:05 Bocian-1

I vote for this !

The KSamplers from Impact Pack already integrate the AYS scheduler. But we can't use certain nodes like the KSampler Config (rgthree) because the COMBO list it's different ( they won't connect ).

pipe

May 27 '24 20:05 JorgeR81

I vote for this !

The KSamplers from Impact Pack already integrate the AYS scheduler. But we can't use certain nodes like the KSampler Config (rgthree) because the COMBO list it's different ( they won't connect ).

Impact Pack provides adapter node.

May 28 '24 12:05 ltdrdata

SwarmKSampler integrates it directly in the sampler list as well

Jun 10 '24 19:06 mcmonkey4eva

I see this is now implemented, thank you

Jun 19 '24 12:06 Bocian-1

I see this is now implemented, thank you

Was this also implemented on Comfy UI ?

I don't see it ...

Jun 23 '24 10:06 JorgeR81

I see this is now implemented, thank you

Was this also implemented on Comfy UI ?

I don't see it ...

Have you updated ComfyUI?

I can see them: Is it possible that an extension I have added them there even though it's a base ComfyUI node? When I tried to run it now, it crashed too: cannot access local variable 'sigmas' where it is not associated with a value

Jun 23 '24 20:06 Bocian-1

No, I don't have it. I updated today, before posting.

I even have the new ipndm samplers. But the scheduler list is the same as before.

ays

Jun 23 '24 22:06 JorgeR81

Hmm... I closed this thinking it was added to the base ComfyUI as I can see it even on base Comfy nodes now, but I guess it must've been added by some extension then. It does solve my use case, or will anyway when it stops crashing, but I'll reopen this, since I believe getting this in base Comfy is worthwhile

Jun 23 '24 23:06 Bocian-1

Hmm... I closed this thinking it was added to the base ComfyUI as I can see it even on base Comfy nodes now, but I guess it must've been added by some extension then. It does solve my use case, or will anyway when it stops crashing, but I'll reopen this, since I believe getting this in base Comfy is worthwhile

That was bug of Efficiency Nodes. They are gone after patched.

Jun 24 '24 00:06 ltdrdata

This custom node suite now adds the AYS schedulers directly to the KSampler node. https://github.com/pamparamm/ComfyUI-ppm?tab=readme-ov-file#schedulers

I didn't try it, but it seems to be working. https://www.youtube.com/watch?v=JgYzCEzHDrc ( Nerdy Rodent initially thought it was a Comfy UI default update, but then corrected in the comments ).

Jul 23 '24 20:07 JorgeR81

This issue is being marked stale because it has not had any activity for 30 days. Reply below within 7 days if your issue still isn't solved, and it will be left open. Otherwise, the issue will be closed automatically.

Nov 14 '24 11:11 github-actions[bot]

I still think it would be great to have this in the native ComfyUI samplers !

Nov 14 '24 11:11 JorgeR81

This issue is being marked stale because it has not had any activity for 30 days. Reply below within 7 days if your issue still isn't solved, and it will be left open. Otherwise, the issue will be closed automatically.

Dec 16 '24 11:12 github-actions[bot]

This is more like a feature request, not a bug, so I think it should stay open.

Dec 16 '24 14:12 JorgeR81

Can we just have AYS scheduler inside Ksampler, and avoid adding yet another plugin to make comfy more bloated? Thank you!

Dec 22 '24 13:12 LiJT