ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Add optional noise_seed to make augmentation deterministic

Open harelc opened this issue 10 months ago • 4 comments

As currently implemented, SVD_img2vid_Conditioning has an optional augmentation stage with non-deterministic noising of the conditioning image, which prevents one from reproducing exact results in an SVD pipeline if augmentation is used.

I'm suggesting an optional (change widget to input port to ignore) noise_seed for the augmentation stage.

harelc avatar Apr 17 '24 09:04 harelc

A more proper way is doing it with a generator like this: https://github.com/comfyanonymous/ComfyUI/blob/master/comfy/sample.py#L13

comfyanonymous avatar Apr 17 '24 15:04 comfyanonymous

@comfyanonymous changed as requested. This kind of mandates the seed to be a required, not optional, argument, so I changed accordingly.

harelc avatar Apr 18 '24 07:04 harelc

@harelc the generator can be None when no seed is supplied and it'll use the "global" RNG.

asagi4 avatar Apr 18 '24 16:04 asagi4

@asagi4 ok, did as you suggested.

harelc avatar Apr 21 '24 07:04 harelc