ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Ensure samplers seed the global RNG even when add_noise is disabled

Open blepping opened this issue 2 years ago • 0 comments

currently no global RNG seed gets set at all with the built in samplers (advanced KSampler, SamplerCustom) if add_noise is not enabled. this means anything using the global RNG (i.e. euler_a) will find the RNG in an undefined state. it becomes impossible to reproduce generations.

this simple pull just ensures torch.manual_seed() gets called even in the non-add_noise code path.

visual demonstration:

current behavior

image

with this pull

image


unfortunately, a lot of other custom nodes copy the current ComfyUI code with this issue and will need to be changed individually.

closes #2833 (i hope)

blepping avatar Feb 19 '24 16:02 blepping