ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Update Version of Pytorch Lightning in ComfyUI Portable Download

Open camoody1 opened this issue 1 year ago • 4 comments

I'm actually not sure if I'm even asking the right question, here, but with the new LDSR node released by Flowtyone this week, many users are getting error messages when attempting to run workflows stating we are running the wrong version of "pytorch lightning". In order to get this to work for us, we have to make the following change to his code in the file ddpm.py:

Change from... from pytorch_lightning.utilities.distributed import rank_zero_only

To... from pytorch_lightning.utilities.rank_zero import rank_zero_only

I'm not at all knowledgeable about such things, but I figured since I'm using an unzipped file from your repository for my ComfyUI installation, maybe I should start here with you.

Please let me know if any of this makes sense.

Thank you!

camoody1 avatar Jan 06 '24 07:01 camoody1

Worked! Thanks so much!

orbithammer avatar Jan 07 '24 09:01 orbithammer

@camoody1 wait - are you saying that we should NOT upgrade pytorch-lightning 1.7.7 and instead change the ddpm.py file? I've always wondered what would happened if i upgrade but didn't want to risk the 60+ node packs i have installed... If you know the answer, please let me know so i can run some tests, thank you.

stephantual avatar Feb 07 '24 11:02 stephantual

@camoody1 wait - are you saying that we should NOT upgrade pytorch-lightning 1.7.7 and instead change the ddpm.py file? I've always wondered what would happened if i upgrade but didn't want to risk the 60+ node packs i have installed... If you know the answer, please let me know so i can run some tests, thank you.

As I wrote in my previous comment, I really have NO idea what any of that means. I just updated the code as stated and it started to work. I'm sorry that I can't be more helpful.

camoody1 avatar Feb 08 '24 00:02 camoody1

Flowtyone

how does one update pytorch? been struggling with this.

alenknight avatar Feb 15 '24 15:02 alenknight