ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Quality of life issues:

Open WolfExplode opened this issue 2 years ago • 8 comments

Problem: When I use middle mouse to navigate and pan, the middle mouse causes a node router to appear if middle clicking on a node. This is incredibly frustrating. when middle clicking on text field, it enters it.

Solution: Middle click should be navigation only

-Is there a way to force nodes to snap to grid? Like a toggle default functionality, without having to hold shift. -It would be nice if I could edit group names by double clicking -Is it possible to add a time above each node, to indicate how long each node took to finish?

WolfExplode avatar Nov 04 '23 16:11 WolfExplode

Problem: When a group is inside of another group, we can't resize the smaller group's window since the group overlaps. ComfyUI_GroupResize

Problem: If the node is too large, it will block the resizer Problem: When creating a new group and resizing it, If the edge of the group overlaps any node, that node is automatically considered part of that group. Proposed solution: When dragging nodes to groups, the group window should automatically resize to encompass the containing nodes. Only nodes fully encompassed by the group should belong to that group

I would also like the ability to change the window size from the left instead of only bottom right

WolfExplode avatar Nov 04 '23 17:11 WolfExplode

When panning using middle mouse button, clicking on a node input causes it to break. once again, I would like middle click to be navigation only. ComfyUI_MiddleMousePan

WolfExplode avatar Nov 04 '23 17:11 WolfExplode

The middle-click behavior you show is part of a mod, you can change that under the settings menu. Find "middle click slot to add" and change it to "none".

Of course you can't interact with a group that is under another group... in the same way you can't interact with a window that is underneath another window. Why would you expect to be able to? Now had you suggested the ability to properly nest group boxes I would have agreed with you that it would be a nice new feature, but right now you cannot do that.

There are SIX HUNDRED something "issues" here... subjective things like this should not be reported as if they were actual problems. It's just way too much noise and distracts from more important things.

CHollman82 avatar Nov 06 '23 08:11 CHollman82

You raise some very valid points! However, please keep in mind that Quality of life issues are still issues, despite not being technical in nature. If I don't post here can you suggest a better alternative?

"The middle-click behavior you show is part of a mod, you can change that under the settings menu. Find "middle click slot to add" and change it to "none"." Which mod are you referring to? I am unable to replicate your proposed solution. As far as I could tell it's part of comfyui's default functionality. using a new installation of comfyui, yields the same problematic behavior: ComfyUI_MiddleMousePan

You mentioned: "Of course you can't interact with a group that is under another group" That's the problem, why should smaller groups be under another group instead of being on top? You also mentioned: "Now had you suggested the ability to properly nest group boxes" I mentioned "Proposed solution: When dragging nodes to groups, the group window should automatically resize to encompass the containing nodes. Only nodes fully encompassed by the group should belong to that group"

Please read my entire post before writing a reply. 🤗Thank you for your understanding 🤗

WolfExplode avatar Nov 06 '23 21:11 WolfExplode

image

Perhaps it is the mod that allows you to change the middle-click behavior. When set to "none" I can pan with the middle mouse button without the issue you are showing. I'm not sure which mod it is since I have so many enabled and it doesn't tell you anywhere what nodes come from what mods but I have several nodes with that snake emoji in their name.

You're right that overlapping group boxes has an issue, I didn't understand what you meant at first but after trying it it's clear. In fact it's worse than you suggest, the overlapped group box can have it's content "stolen" by the group box in front of it if you move it. At this point it's clearly best to simply not overlap group boxes at all.

CHollman82 avatar Nov 07 '23 07:11 CHollman82

Well unfortunately the overlapping group box behavior is not going to be fixed... the author of ComfyUI is using another project called LiteGraph and it has the same problem. You can see a demo of LiteGraph running here, and confirm the problem exists there as well:

https://tamats.com/projects/litegraph/editor/

If you want this fixed you should ask for it on that project page here:

https://github.com/jagenjo/litegraph.js

CHollman82 avatar Nov 09 '23 19:11 CHollman82

Searched for "group snap" and figured I'd also chime in to feature request moving group while snapping to grid

aphaits avatar Apr 25 '24 02:04 aphaits

For the middle click issue, I figured it out as you maybe using Linux. This is an annoying feature on Wayland desktop environment which cause middle mouse to do both middle click and pasting at same time. ComfyUI seem to put in a default node if middle click paste something else other than a node.

You should be able to disable this feature in your System Setting. If you are using Firefox, you can head to the address about:config and change middlemouse.paste to false.

RokuDoan avatar May 09 '24 03:05 RokuDoan