ComfyUI icon indicating copy to clipboard operation
ComfyUI copied to clipboard

Add docker to installation instructions

Open robballantyne opened this issue 1 year ago • 6 comments

relates to issue #1339

Adds reference to a fully documented cloud-oriented docker image for use at RunPod, Vast, Paperspace and others.

robballantyne avatar Aug 26 '23 08:08 robballantyne

I think this will be better to merge this PR (https://github.com/comfyanonymous/ComfyUI/pull/1469) and to include a docker/docker-compose install in the main repo

julien-blanchon avatar Nov 05 '23 23:11 julien-blanchon

I think this will be better to merge this PR (#1469) and to include a docker/docker-compose install in the main repo

Unfortunately there is no docker compose support in the intended environments (runpod, vast etc) so this image has to include extras for usability:

  • Reverse proxy for authentication support
  • Logging Web UI
  • ... As documented

robballantyne avatar Nov 06 '23 05:11 robballantyne

Yes, your repo is fantastic but it include much more than just ComfyUI and things that may not belong here. If I docker may be include here it must be a minimal one. Btw I love the rclone feature of your repo <3

julien-blanchon avatar Nov 06 '23 13:11 julien-blanchon

But a note in the README is fine I suppose, howerver we are still waiting for the https://github.com/comfyanonymous/ComfyUI/pull/1469 PR to be merged

julien-blanchon avatar Nov 06 '23 13:11 julien-blanchon

Thank you. Yes it's far more than ComfyUI, so I only suggested a Readme note for those of us without GPUs.

The PR you referenced is more important than this in ComfyUI's own scope, this is really an extra - Though it's also fine for local use, it's not the 'docker way', but these services offer one container only, so everything has to be bundled.

robballantyne avatar Nov 06 '23 14:11 robballantyne

I support the idea of adding a Dockerfile / docker-compose.yml in the repo. Containers are the best way to run these UIs IMHO, even locally

Reezlaw avatar Dec 21 '23 23:12 Reezlaw