rust-shlex icon indicating copy to clipboard operation
rust-shlex copied to clipboard

Format files using rustfmt

Open Rolv-Apneseth opened this issue 1 year ago • 2 comments

Split from #16

I guess I'll do these sequentially? They'll all be conflicting otherwise. If you don't want this format one let me know and I'll move on to the clippy warnings.

Rolv-Apneseth avatar Nov 14 '23 19:11 Rolv-Apneseth

I'm going to need some time to review this. My first impression is that a lot of the changes are making things harder to read, for example the inconsistency introduced in the asserts, and the extra braces around match arm bodies. I'll have to do some research on why rustfmt does these things.

fenhl avatar Nov 15 '23 13:11 fenhl

Sure thing, take your time. Maybe for more consistent asserts I could increase the line length to something that keeps them all on one line. Personally I think the changes make it more readable but of course that's just personal preference and this is not my project so I have no issue skipping this formatting step.

Rolv-Apneseth avatar Nov 15 '23 13:11 Rolv-Apneseth