opik icon indicating copy to clipboard operation
opik copied to clipboard

feat: added the ability to select tags for multiple tags

Open Gmin2 opened this issue 7 months ago • 5 comments

Details

Added the ability to Tag multiple traces at once within a Project

Issues

Resolves #1009

Testing

https://github.com/user-attachments/assets/8217068c-fd97-4384-b2b3-2363bfdc70ba

/claim #1009

Gmin2 avatar May 25 '25 11:05 Gmin2

@Gmin2 will review as soon as possible. Thanks for your contribution Can you verbally agree to the CLA.md with "i accept the CLA" in a comment please.

vincentkoc avatar May 25 '25 11:05 vincentkoc

i accept the CLA

Gmin2 avatar May 25 '25 12:05 Gmin2

@Gmin2 thanks. Changes look good, thanks for the video also. Will get one of the product engineers to take a look and review over the next few days.

vincentkoc avatar May 25 '25 13:05 vincentkoc

We've discussed it with our FE team and decided that we need to do updates of traces and spans in batches here. So, it will likely require the BE work as well. Will you consider doing it?

yes, can yu share how you have plan to do that?

Gmin2 avatar May 27 '25 17:05 Gmin2

@Gmin2

yes, can yu share how you have plan to do that?

So, implementing the back-end part to support batch updates should also be included in this PR and should be done by the person seeking the bounty. Could you implement the back-end part?

aadereiko avatar May 28 '25 10:05 aadereiko

@Gmin2 We've discussed this PR within our team and realized that the backend changes were not part of the initial requirements. We'll handle those improvements ourselves later. On your side, you can simply add a limit of up to 10 traces.

Also, you have some eslint issue:

Error:    49:29  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
Error:    68:13  error  Insert `,`                                prettier/prettier
Error:    85:[13](https://github.com/comet-ml/opik/actions/runs/15342488982/job/43181043429?pr=2254#step:5:14)  error  Insert `,`                                prettier/prettier
Error:   105:15  error  'error' is defined but never used         @typescript-eslint/no-unused-vars
Error:   [14](https://github.com/comet-ml/opik/actions/runs/15342488982/job/43181043429?pr=2254#step:5:15)2:29  error  Insert `⏎`                                prettier/prettier

Please, before submitting a PR, run npm run lint from opik-frontend repo to see what stylistic error you need to fix :)

aadereiko avatar May 30 '25 11:05 aadereiko

Resolved the linting issues !

Gmin2 avatar Jun 03 '25 10:06 Gmin2

can i get approved on this?

Gmin2 avatar Jun 11 '25 09:06 Gmin2

hey @Gmin2 , could you please add limits of adding tags to up to 10 entities and we can approve?

aadereiko avatar Jun 12 '25 09:06 aadereiko

hey @Gmin2 , could you please add limits of adding tags to up to 10 entities and we can approve?

hey @aadereiko just done that could you review it once !

Gmin2 avatar Jun 13 '25 05:06 Gmin2

@Gmin2 we'll add error handling on our end and merge this PR soon, thanks! I guess your work here is done FYI @vincentkoc

aadereiko avatar Jun 16 '25 15:06 aadereiko

@Gmin2 we'll add error handling on our end and merge this PR soon, thanks! I guess your work here is done FYI @vincentkoc

cc @vincentkoc

Gmin2 avatar Jun 18 '25 14:06 Gmin2

@Gmin2 yes I have seen this. Wont be long once the team make the additional changes and this PR is merged you will be paid out. Easier to keep to this approach, but as discussed consider this one locked in. If any delays on our side I will process the bounty manually.

vincentkoc avatar Jun 18 '25 16:06 vincentkoc