mleap icon indicating copy to clipboard operation
mleap copied to clipboard

Published 20 hours ago • verified publisher icon combust

Upgrade spark dependency to 3.3.0

Open WeichenXu123 opened this issue 2 years ago • 9 comments

Upgrade spark dependency to 3.3.0

Closes https://github.com/combust/mleap/pull/823

WeichenXu123 avatar Aug 15 '22 09:08 WeichenXu123

CC @jsleight Could you help review and merge if it is good ?

WeichenXu123 avatar Aug 15 '22 10:08 WeichenXu123

CC @jsleight Could you help review and merge if it is good ?

The CI does not run on my last commit, could you help fix it ?

WeichenXu123 avatar Aug 15 '22 13:08 WeichenXu123

CC @jsleight Thanks!

WeichenXu123 avatar Aug 18 '22 11:08 WeichenXu123

CC @jsleight Thanks!

WeichenXu123 avatar Aug 19 '22 01:08 WeichenXu123

CC @jsleight Thanks!

WeichenXu123 avatar Sep 01 '22 03:09 WeichenXu123

Can please someone review this PR and maybe merge? Pretty please? Mleap is currently blocking Spark upgrades to latest stable… Thank you! :D

realknorke avatar Sep 08 '22 07:09 realknorke

@WeichenXu123 @realknorke sorry, we had run out of credits for travis CI, can you please push a dummy commit to trigger the build now? will merge it once it's green.

ancasarb avatar Sep 14 '22 12:09 ancasarb

CC @ancasarb PR is ready for merging :)

WeichenXu123 avatar Sep 16 '22 12:09 WeichenXu123

So before we merge this do we want to do one last mleap release on spark 3.2? There have been a reasonable number of bug fixes since last release and we might want to ship those out before requiring folks to do the spark 3.3 upgrade? cc @ancasarb

jsleight avatar Sep 22 '22 20:09 jsleight

CC @jsleight Can we merge now :) ?

WeichenXu123 avatar Sep 29 '22 13:09 WeichenXu123

Personally I would like to release all the 3.2.x fixes before this upgrade, but I think only @ancasarb has the release keys.

jsleight avatar Sep 29 '22 15:09 jsleight

OK fine. Let's wait. CC @ancasarb

WeichenXu123 avatar Sep 30 '22 03:09 WeichenXu123

CC @jsleight @ancasarb Any progress ? Thank you.

WeichenXu123 avatar Oct 27 '22 11:10 WeichenXu123

@jsleight Thank you!

WeichenXu123 avatar Nov 04 '22 12:11 WeichenXu123

This topic (Spark3.3) is getting more and more urgent. Would it be possible to at least create a release candidate for the next mleap release?

realknorke avatar Feb 08 '23 12:02 realknorke

@jsleight Can we release it for spark 3.3 ? :)

WeichenXu123 avatar Feb 08 '23 14:02 WeichenXu123

releasing a new mleap version sgtm. I might have time to do this next week.

jsleight avatar Feb 08 '23 15:02 jsleight

Thank you very much, guys! :D

realknorke avatar Feb 08 '23 16:02 realknorke

@jsleight Can you please release a new version w/ Spark 3.3.2 support and I'll buy you a beer! ;)

realknorke avatar Feb 23 '23 10:02 realknorke

Apologies for the delay. I just finished releasing mleap v0.22.0 which is on spark 3.3.0. See the release notes for the full changelong. You should see the relevant artifacts on sonatype and pypi. Cheers!

jsleight avatar Feb 24 '23 19:02 jsleight