mill icon indicating copy to clipboard operation
mill copied to clipboard

Ci `publishDocs` workflow failes due to invalid page links

Open lefou opened this issue 1 week ago • 2 comments

For example: https://github.com/com-lihaoyi/mill/actions/runs/20192594269/job/57972081300#logs

6522] [13:31:20.746] ERROR (asciidoctor): target of xref not found: mill:ROOT:comparisons/performance.adoc#_mill_vs_gradle
6522]     file: /home/runner/work/mill/mill/out/website/blogFolder.dest/modules/ROOT/pages/1-java-compile.adoc
6522]     source: /home/runner/work/mill/mill (branch: main <worktree> | start path: out/website/blogFolder.dest)

6522] [13:31:20.747] ERROR (asciidoctor): target of xref not found: mill:ROOT:comparisons/performance.adoc#_mill_vs_maven
6522]     file: /home/runner/work/mill/mill/out/website/blogFolder.dest/modules/ROOT/pages/1-java-compile.adoc
6522]     source: /home/runner/work/mill/mill (branch: main <worktree> | start path: out/website/blogFolder.dest)

6522] [13:31:20.748] ERROR (asciidoctor): target of xref not found: mill:ROOT:comparisons/performance.adoc
6522]     file: /home/runner/work/mill/mill/out/website/blogFolder.dest/modules/ROOT/pages/1-java-compile.adoc
6522]     source: /home/runner/work/mill/mill (branch: main <worktree> | start path: out/website/blogFolder.dest)

6522] [13:31:20.867] ERROR (asciidoctor): target of xref not found: mill::comparisons/performance.adoc
6522]     file: /home/runner/work/mill/mill/out/website/blogFolder.dest/modules/ROOT/pages/12-direct-style-build-tool.adoc
6522]     source: /home/runner/work/mill/mill (branch: main <worktree> | start path: out/website/blogFolder.dest)

6522] [13:31:20.888] ERROR (asciidoctor): target of xref not found: mill::comparisons/performance.adoc
6522]     file: /home/runner/work/mill/mill/out/website/blogFolder.dest/modules/ROOT/pages/13-mill-build-tool-v1-0-0.adoc
6522]     source: /home/runner/work/mill/mill (branch: main <worktree> | start path: out/website/blogFolder.dest)

6522] [13:31:21.322] ERROR (asciidoctor): target of xref not found: mill::comparisons/performance.adoc
6522]     file: /home/runner/work/mill/mill/out/website/blogFolder.dest/modules/ROOT/pages/index.adoc
6522]     source: /home/runner/work/mill/mill (branch: main <worktree> | start path: out/website/blogFolder.dest)

lefou avatar Dec 13 '25 13:12 lefou

This should be fixed once we tag a new version and the main doc site picks up the latest changes

lihaoyi avatar Dec 13 '25 13:12 lihaoyi

We probably don't want to block publish jobs due to such issues. Instead, we should have these checks as part of the pull request verification.

lefou avatar Dec 13 '25 13:12 lefou

This should be fixed once we tag a new version and the main doc site picks up the latest changes

If we can't publish via CI action, how is the next CI job supposed to pick up the unpublished changes? Do we skip the checks on a tag?

lefou avatar Dec 15 '25 06:12 lefou