mill icon indicating copy to clipboard operation
mill copied to clipboard

Add Kotlin-specific data in BSP build targets

Open alexarchambault opened this issue 1 year ago • 2 comments

This PR adds Kotlin-specific data in BSP build targets of KotlinModules. This is meant to comply with how intellij-bsp seems to expect Kotlin details. If the IntelliJ version we talk to via BSP doesn't seem to support such data (that is, it doesn't claim to support Kotlin via BSP), we keep trying to have intellij-scala handle Kotlin modules, like done in https://github.com/com-lihaoyi/mill/pull/3643.

alexarchambault avatar Oct 01 '24 14:10 alexarchambault

Includes https://github.com/com-lihaoyi/mill/pull/3608 and https://github.com/com-lihaoyi/mill/pull/3643 for now

alexarchambault avatar Oct 01 '24 14:10 alexarchambault

On hold because:

  • this breaks binary compatibility (although this could be overcome with some refactoring)
  • IntelliJ doesn't use the extra data we add in BSP responses yet, so there's no hurry to have them

alexarchambault avatar Oct 17 '24 13:10 alexarchambault

Closing this for now since it's stale, feel free to re-open a new one if necessary

lihaoyi avatar Jul 01 '25 15:07 lihaoyi