GridFieldBulkEditingTools
GridFieldBulkEditingTools copied to clipboard
Select all checkbox doesn't have a visuable label anymore
2c40a16198aea55fc2c34835fdcddef0d4ead058 removed the title for the select all checkbox, to be precise:
<% _t('GRIDFIELD_BULK_MANAGER.SELECT_ALL_LABEL', $Select.Label) %>
This causes the checkbox to look out of place - or a misrendered checkbox -, see e.g. the screenshot from the Comments tab:
While it is not hard to add this back into the label, the spacing causes some issues since 'Select all' would wrap over two lines...
Tried fixing this with white-space: no-wrap
which caused the text to be disaligned...
Sorry don't have more time to look into this today, but wanted to capture this somehow.
Yeah I know what you mean... All would probably be solved if we have the checkboxes on the left of the gridfield and the select-all box in the gridfield header.
+1 for moving it to the left. I think in that case not having a label would be fine, because most web UIs that have a select all feature would look like that anyway so people would usually understand what it does. We'd still need to provide an aria label though for screen readers.