midi-parser-js icon indicating copy to clipboard operation
midi-parser-js copied to clipboard
verified publisher icon colxi

Bugs? about uncategorized meta-events

Open Eggrice62 opened this issue 4 years ago • 3 comments

Hello! Thanks for making such a nice module. There seems to be a bug where lines 263-264 in main.js (commit 310b076 on 11 Mar 2021), which read a file twice as long as metaEventLength. Among the MIDI files I have, there are files in which an error occurs due to the syntax. I corrected the above and it was solved. I'll send you the MIDI file if you want. Please provide your contact information.

Eggrice62 avatar Sep 25 '21 00:09 Eggrice62

Can you open a PR with the fix, so I can take a look at it? Thanks for reporting!

colxi avatar Sep 26 '21 12:09 colxi

I opened a pull request. Please take a look!

Eggrice62 avatar Sep 27 '21 14:09 Eggrice62

ping.

DJthefirst avatar Jul 30 '23 22:07 DJthefirst