react-native-modalfy icon indicating copy to clipboard operation
react-native-modalfy copied to clipboard

Refactor: Migrate to reanimated 2

Open ngocle2497 opened this issue 2 years ago • 9 comments

This PR uses Reanimated 2 to be supported by JSI instead of Bridge

ngocle2497 avatar Mar 11 '22 13:03 ngocle2497

Hey @MasonLe2497! Thank you for this great PR! I've been thinking about switching Modalfy to Reanimated v2 for a long time, just was waiting to ship some other features & fixes before that. I'll go over your PR and try to get it merge as soon as I'll have a minute! 💪

CharlesMangwa avatar Mar 11 '22 14:03 CharlesMangwa

I tested on android device, and it works with 60fps https://user-images.githubusercontent.com/43195241/157888496-336df1f1-d2c0-4dad-aeb4-2abeb29b9c4d.mov

ngocle2497 avatar Mar 11 '22 14:03 ngocle2497

But with this PR, transitionOptions must be a 'worklet' function return ViewStyle

ngocle2497 avatar Mar 11 '22 14:03 ngocle2497

Yeah, I suspected that the switch to Reanimated 2 would be a breaking change and would require a major app update, shouldn't be much of an issue if the doc has proper migration guide.

CharlesMangwa avatar Mar 11 '22 14:03 CharlesMangwa

Hey! I'm looking into migrating to this library and v2 reanimated support is something on our list, is there any chance this is on the docket still? Love the lib design so far too nice work

LeviWilliams avatar Jun 07 '22 15:06 LeviWilliams

@MasonLe2497 Thinking about patching this into my project, have you used in production at all? Thanks!

LeviWilliams avatar Jul 14 '22 15:07 LeviWilliams

hey! is this still being worked on? I'd love to see modalfy having support for reanimated 😄

tonihm96 avatar Feb 19 '23 22:02 tonihm96

hi @Tonihm96. no this is currently not being worked on. we'll try to keep you posted once this gets on top of our todo list 👍

CharlesMangwa avatar Feb 20 '23 08:02 CharlesMangwa

would love to see modalfy having support for reanimated !

GaeCuure avatar Jul 21 '23 08:07 GaeCuure