react-native-modalfy icon indicating copy to clipboard operation
react-native-modalfy copied to clipboard

Published 20 hours ago • verified publisher icon colorfy-software

fix: displaying the modal in a screen with presentation: modal on iOS

Open fobos531 opened this issue 8 months ago • 0 comments

Fixes https://github.com/colorfy-software/react-native-modalfy/issues/125

This is actually a super simple solution, all that is needed is to just wrap the ModalStack in a FullWindowOverlay provided by react-native-screens.

This now works on iOS both with presentation: modal and regular screens.

The behavior is unchanged on Android since it is unaffected by this problem.

@CharlesMangwa I would very much appreciate if you could take a look at this and review it.

Also, there are a couple of things that could be done to modernise this library, like updating gesture handler to v2, as well as migrating to Reanimated. Would you be open to reviewing a PR doing the migration to reanimated 3, like https://github.com/colorfy-software/react-native-modalfy/pull/68?

fobos531 avatar Jun 28 '24 12:06 fobos531