colobot icon indicating copy to clipboard operation
colobot copied to clipboard
verified publisher icon colobot

Make try interrupt goto() v2

Open hexagonrecursion opened this issue 1 year ago • 7 comments

  • This is a revised version of #1622
  • Fixes #474

I decided to post this as a new pull request because I have reconsidered major parts of the implementation.

Valgrind

hexagonrecursion avatar Jul 06 '24 15:07 hexagonrecursion

Hold on. I found a bug

hexagonrecursion avatar Aug 05 '24 05:08 hexagonrecursion

Should be fixed now

hexagonrecursion avatar Aug 05 '24 09:08 hexagonrecursion

Resolved merge conflicts and ready for review

valgrind ./Colobot-UnitTests --- 0 errors valgrind ./Colobot-UnitTests --CBotUT_TestSaveState --- 0 errors

hexagonrecursion avatar Oct 04 '24 10:10 hexagonrecursion

Who should I ask to review this?

hexagonrecursion avatar Dec 09 '24 19:12 hexagonrecursion

I'll review it within a couple of days.

tomaszkax86 avatar Dec 09 '24 19:12 tomaszkax86

  • Should I put this on hold until after we are done with https://github.com/melex750/colobot/pull/2 ?
  • There will git conflicts. I think it would be easier to merge https://github.com/melex750/colobot/pull/2 first and then rebase https://github.com/colobot/colobot/pull/1684

hexagonrecursion avatar Jan 04 '25 07:01 hexagonrecursion

Sorry for lack of updates. I started the review but then Christmas made me busy, the number of other PRs grew, we had a release and I got overwhelmed.

I checked some of the context PR but not all of it. Looks very promising but I'll have to keep up with the conversations that are happening there first before I can say something more substantial. If you recommend that the other PR should be merged first then we can postpone this one for later.

tomaszkax86 avatar Jan 04 '25 13:01 tomaszkax86