Collin Chin

Results 84 comments of Collin Chin

> Well, the change I'm referring to is the removal of `[constants]` section titles from input files. Neither #1739 nor #1746 removes those (i.e. they are still in the testnet3...

Moving this feature to a future sprint. Will be marking as low priority for now.

Thanks for writing this up @gluax! I have a few comments for discussion: Syntax 1 requires adding a `Bytes` circuit to the core module. At the top of the file,...

The `to_bits` rust gadget returns a vector of booleans. The `to_bytes` rust gadget returns a vector of u8's. The types that have rust gadgets implemented are `ints`, `uints`, `fields`, `groups`,...

> I was also wondering about endianness. Would the bits/bytes be big endian or little endian? Should both options be provided? > > > > E.g.: > > ``` >...

@acoglio I think we should start a separate proposal for a type casting to bits/bytes syntax after #600 is implemented. I also think that specifying endianness + reversing endianness should...

# Implementation @gluax To finalize, this proposal can be closed by implementing: - [ ] `.bits()` / `.bytes()` syntax for unsigned integers `u8`, `u16`, `u32`, `u64`, `u128` - [ ]...

Will revisit after `testnet3` refactor