SavvyCAN icon indicating copy to clipboard operation
SavvyCAN copied to clipboard

Importing TRC Files with Extended Frames Reads as Standard Frame

Open nlopified opened this issue 1 year ago • 0 comments

Given this test file here, we would expect these frames (5, 6, 7, 13, 14, and 15) to show as Standard Frames and all others in the test log to show as Extended Frames (given that their IDs are greater than 0x7FF).

In the framefileio.cpp file, under bool FrameFileIO::loadPCANFile( we see that an extended frame is only set when the 29th bit of the ID is equal to 1.

if (thisFrame.frameId() > 0x10000000)
{
    thisFrame.setExtendedFrameFormat(true);
}
else
{
    thisFrame.setExtendedFrameFormat(false);
}

Instead the first line of the detection should be: if (thisFrame.frameId() > 0x7FF)

This issue is seen on lines 1443, 1495, 1537, and 1589 on Release V213.

SavvyCAN_TestLog.trc.txt

nlopified avatar Apr 23 '24 15:04 nlopified