Marco Colli

Another related question... If I use the sync push, and I add the "on error" callback: ``` connection = Apnotic::Connection.new(cert_path: StringIO.new(apns_cert)) connection.on(:error) { |exception| puts "Exception has been raised: #{exception}"...

> What happens to the main code when there is an exception in the background thread? > Does connection.push raises an exception? Does it return nil? Ok, it seems that...

+1 for this, it would be useful to have this update merged (and most importantly having this merged before support for previous openssl versions is dropped...)

I am looking at the code line by line and in general seems good to me. However I have some doubts about the use of `OpenSSL::ASN1::Sequence` in `VapidKey#to_pem` and `VapidKey#set_keys!`...

Are these changes necessary at all? Please try to use this https://github.com/pushpad/web-push (v2.0.0) and simply **update the openssl version in the .gemspec to v3**: ``` spec.add_dependency 'openssl', '~> 3.0' ```...

Ok, the gem version (e.g. v3) can be different from the underlying C library. For example openssl gem v3 is still compatible with C library v1.1. The breaking change seems...

@ClearlyClaire Great! I wonder if it's possible to use a similar, high-level approach also for `set_keys!`

@mohamedhafez Do you still see that issue? I haven't seen any problems and this can probably be closed

I have released a new version (v2.0) of this gem with many improvements, updates and bug fixes: https://github.com/pushpad/web-push It is called `gem 'web-push'` (instead of `webpush`) and the module is...

The changelog is here: https://github.com/pushpad/web-push/releases