ormar icon indicating copy to clipboard operation
ormar copied to clipboard

Slicing QuerySet Result Objects

Open SepehrBazyar opened this issue 2 years ago • 5 comments

SepehrBazyar avatar Jul 28 '22 16:07 SepehrBazyar

Codecov Report

Merging #765 (8a8186e) into master (e923513) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #765   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          192       192           
  Lines        16057     16140   +83     
=========================================
+ Hits         16057     16140   +83     
Impacted Files Coverage Δ
ormar/queryset/queryset.py 100.00% <100.00%> (ø)
ormar/queryset/utils.py 100.00% <100.00%> (ø)
ormar/relations/querysetproxy.py 100.00% <100.00%> (ø)
tests/test_queries/test_pagination.py 100.00% <100.00%> (ø)

codecov-commenter avatar Jul 28 '22 17:07 codecov-commenter

Hi @collerek Thank you, please, if you do the review.

SepehrBazyar avatar Aug 05 '22 06:08 SepehrBazyar

What about slicing also the querysetproxy to allow slicing the related models?

collerek avatar Aug 25 '22 12:08 collerek

@collerek Were these changes desirable and correct?

SepehrBazyar avatar Sep 13 '22 13:09 SepehrBazyar

@collerek Were these changes desirable and correct?

@collerek Do I need to make another change for this?

SepehrBazyar avatar Mar 27 '23 20:03 SepehrBazyar