json_spec icon indicating copy to clipboard operation
json_spec copied to clipboard

Published 20 hours ago • verified publisher icon collectiveidea

Add support for MiniTest

Open blowmage opened this issue 13 years ago • 12 comments
trafficstars

Allow json_spec to be used from minitest tests.

blowmage avatar Oct 29 '12 22:10 blowmage

Awesome, thank you! :clap: I don't personally use MiniTest but I'm going to try to pull somebody in who does to review this before I pull.

laserlemon avatar Oct 31 '12 17:10 laserlemon

@blowmage this is a very nice addition, thank you! :+1: from me.

phlipper avatar Oct 31 '12 17:10 phlipper

@laserlemon: @jasonroelofs keeps talking about how we should use MiniTest more, he might be a good candidate

gaffneyc avatar Oct 31 '12 19:10 gaffneyc

By all means @jasonroelofs, please chime in!

laserlemon avatar Oct 31 '12 20:10 laserlemon

Well you guys know me, I love MiniTest and anything that helps people use MiniTest more is :+1: from me!

jasonroelofs avatar Oct 31 '12 20:10 jasonroelofs

@jasonroelofs If you get a second, could you take a look at the commits/changes and let us know how it looks from another MiniTest user's perspective?

laserlemon avatar Oct 31 '12 21:10 laserlemon

@blowmage I swear I don't distrust you as much as it sounds in this thread!

laserlemon avatar Oct 31 '12 21:10 laserlemon

@laserlemon lulz!

blowmage avatar Oct 31 '12 21:10 blowmage

Nothing jumps out at me with this commit. As it is trying to keep the syntax of json_spec the same while allowing the use of MiniTest or Rspec under the hood I'd say it's done a good job of that.

jasonroelofs avatar Oct 31 '12 21:10 jasonroelofs

+1

rdamborsky avatar Dec 13 '12 20:12 rdamborsky

Hi is this pulled? We'd like to make use of your gem in our minitest specs. Thx!!

johnsinco avatar Apr 15 '13 20:04 johnsinco

+1

benwoodward avatar Jun 15 '15 23:06 benwoodward