delayed_job
delayed_job copied to clipboard
collectiveidea
Add no-wait and force-kill-waittime options to Delayed::Comand
I've added support to these options that are used for Daemons gems.
In our case we have some long running jobs that we don't want to be locked when the process is killed on a new deployment, with these we avoid that problem and the process is going to still running after the current job is completed. Later our monitor system will start a new process.
What do you think? is this too specific to the daemons gem? I don't find another way to pass options to the daemons gem
I want to use this. Because, delayed_job's process was frequently force-killed on restart them.
https://github.com/asamix/delayed_job/commit/f762cf7ab5cd953f8cc9a24faeaedf38a30259bd
Will you accept this pull request if I rewrite it to work with current master? I think that it's really useful especially when you suffer from "process with pid X won't stop, we forcefully kill it" as described in #593 /cc @albus522
Is it possible to resolve conflicts in this I think that this feature should be integrated please.
have a more flexible solution that works with any version of the daemons gem here https://github.com/collectiveidea/delayed_job/pull/916
Any plans to update this PR now that #916 was merged? It looks like we would still need the force_kill_waittime option in Delayed::Comand, since it is not an accepted command line option in the daemons gem, so couldn't be passed through daemon-options.
After some research in one of my projects, I agree with @mike-stewart : #916 doesn't solve the problem of passing the force_kill_waittime option, we need another change to support this.
A new switch, --force_kill_waittime, has been added to Daemons in https://github.com/thuehlinger/daemons/pull/65 (not yet released).
Can this Issue be closed since --force_kill_waittime switch has been added to the Daemons gem and no longer needs to be explicitly supported internally in delayed_job?
