audited icon indicating copy to clipboard operation
audited copied to clipboard
verified publisher icon collectiveidea

Re-fix honoring of 'except' when used with 'comment_required'

Open jeffdill2 opened this issue 7 years ago • 7 comments

This was originally fixed here: https://github.com/collectiveidea/audited/pull/419

But it was inadvertently broken when this was merged in: https://github.com/collectiveidea/audited/pull/420

jeffdill2 avatar Mar 20 '18 15:03 jeffdill2

ping @jeffdill2, any updates on this?

tbrisker avatar Apr 10 '18 09:04 tbrisker

@tbrisker Sorry, been a busy couple of weeks. I'll get this addressed today.

jeffdill2 avatar Apr 10 '18 11:04 jeffdill2

@tbrisker OK, I've got a test in place now to ensure this doesn't break again in the future. 😄

jeffdill2 avatar Apr 10 '18 19:04 jeffdill2

@tbrisker Just following up with this one as well. Tests are in place now, so it's ready for review. Thanks!

jeffdill2 avatar May 15 '18 20:05 jeffdill2

@tbrisker OK, should be better now. 😄

jeffdill2 avatar Jul 09 '18 16:07 jeffdill2

@tbrisker merge conflict resolved now.

jeffdill2 avatar Jul 10 '18 14:07 jeffdill2

@tbrisker I've got master merged in now so checks are passing. This should be ready for review/merge whenever you get a chance. 😄

jeffdill2 avatar Aug 22 '18 17:08 jeffdill2