write_riemann thresholds does not honor Hits

[faxm0dem]

• Version of collectd: 5.5.2.20.gaf16be6
• Operating system / distribution: CentOS 6

Expected behavior

When defining a threshold using e.g. Hits 4 the state sent along the events to riemann should take this into account: only change state to warning|critical after 4 intervals of hitting the thresh.

Actual behavior

As soon as the threshold is passed, events start appearing as state warning|critical. Notifications however nicely hit the deck only after 4 iterations.

Steps to reproduce

• define threshold with Hits 1000
• trigger threshold
• query riemann for state != "ok"

[octo]

src/write_riemann_threshold.c duplicates much of the original threshold code. This should be unified while fixing this IMHO.

[eero-t]

src/write_riemann_threshold.c duplicates much of the original threshold code. This should be unified while fixing this IMHO.

@octo Maybe there should be a separate ticket about such unification (referring this ticket)?