journey-book icon indicating copy to clipboard operation
journey-book copied to clipboard

Formalizing Data.json with fewer parameters #179

Open UlbertAO opened this issue 3 years ago • 2 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # 179

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • [*] Test A manually tested if landing page loads as expected with image icons and when navigate to other pages favicon also changes
  • [*] Test B document correction in README.md

Checklist:

  • [*] My code follows the style guidelines of this project
  • [*] I have performed a self-review of my own code
  • [*] I have commented my code, particularly in hard-to-understand areas
  • [*] I have made corresponding changes to the documentation
  • [*] My changes generate no new warnings
  • [*] Any dependent changes have been merged and published in downstream modules

piece of code for Data.json

const fs=require("fs");
let d;
d=JSON.parse(fs.readFileSync("Data.json",'utf8'));
d=d.map(({name,username})=>({name,username}));
fs.writeFileSync("Data.json",JSON.stringify(d))

UlbertAO avatar Oct 13 '22 16:10 UlbertAO

Hi @UlbertAO , Thanks for contributing. But we added the avatar property for those who don't have github profile picture or the user want to use another profile picture as a avatar. This will break flow of the projects. What are your thoughts on this @Adarsh-jaiss ?

vikasganiga05 avatar Oct 19 '22 19:10 vikasganiga05

Hi @vikasganiga05 , @Adarsh-jaiss If that is the case then can we do it like this -if people want their avatar to be same as github profile avatar then they need to specify name and username only -if people want some custom avatar then can add avatar url as well

NOTE: if avatar is not specified in data.json git hub profile avatar will be picked

UlbertAO avatar Oct 22 '22 06:10 UlbertAO