lotusdocs icon indicating copy to clipboard operation
lotusdocs copied to clipboard

Begin fixing landing customization

Open indrora opened this issue 1 year ago • 6 comments

There is a surprising amount of content that depends on $.Site.Data.landing. This is bad and should be removed or made to use something default-but-changeable This changeset does exactly that. I've also reworked the way that iamge compare is checked for, which makes it possible to use it in the body content as well later as a shortcode.

This also begins the process of making all scripts fingerprintable for SRI.

TODO:

  • [x] Reduce uneccesary calls to $.Page.Scratch.Get and related.
  • [ ] add a way to set the default configuration for image comparisons (simple now)
  • [x] Move the script at the end into app.js (w/a check that we have indeed added the script)
  • [x] Pet the dog & drink eggnog.

Changes

  • Move around template logic for the Image Comparison script inclusion. Adding to the end is the right way to do it.
  • Rename landing.yaml to landing_default.yaml -> This should actually be in data/lotusdocs to namespace it away but I didn't want to make any sudden movements.
  • Fixed up references to $.Site.Data.landing to one.
  • Made templates relative to their config data. This allows for multiple instances of each that do not interfere with one another.

fixes #143 and future-proofs it a bit.

indrora avatar Dec 26 '23 09:12 indrora

Deploy request for hugo-lotusdocs pending review.

Visit the deploys page to approve it

Name Link
Latest commit f090b4dcd5ca3e777112c59308e67ba61717f34f

netlify[bot] avatar Dec 26 '23 09:12 netlify[bot]

When is this PR get reviewed potentially merged?

i had to update couple of things by manually to make the landing page works.

Kudos to the creator. 👏 I love this theme.

chapimenge3 avatar Jan 10 '24 12:01 chapimenge3

Nice to see this! It was driving me crazy and then decided to check the issues and prs. Looking forward to it getting merged.

IzzyMusa avatar Jan 18 '24 19:01 IzzyMusa

I'm pretty confident that this is ready for at least an initial review.

Things that should be considered for a future change:

  • Default image comparison options
  • Unify the CSS into one single set of scss instead of weird duplication.

indrora avatar Feb 11 '24 00:02 indrora

knock knock: Any chance of getting this merged?

indrora avatar Mar 12 '24 07:03 indrora

Would be great to see this merged. @colinwilson any chance you can have a look at this?

ManuelLevi avatar Mar 14 '24 12:03 ManuelLevi