bloombroom
bloombroom copied to clipboard
fixed some tests using be_false / be_true instead of be false / be true
Hello,
This PR fixes some tests for newer rubies / rspec by using be false
instead of be_false
and be true
instead of be_true
I still got 4 spec failing (using ruby 2.7.1 on Mac):
Failures:
1) Bloombroom::FNVFFI should generate fnv1_32
Failure/Error: Bloombroom::FNVFFI.fnv1_32(k).should == v
expected: 99318309
got: 3823118551 (using ==)
# ./spec/bloombroom/hash/ffi_fnv_spec.rb:9:in `block (3 levels) in <top (required)>'
# ./spec/bloombroom/hash/ffi_fnv_spec.rb:8:in `each'
# ./spec/bloombroom/hash/ffi_fnv_spec.rb:8:in `block (2 levels) in <top (required)>'
2) Bloombroom::FNVFFI should generate fnv1a_32
Failure/Error: Bloombroom::FNVFFI.fnv1a_32(k).should == v
expected: 182779749
got: 344985583 (using ==)
# ./spec/bloombroom/hash/ffi_fnv_spec.rb:15:in `block (3 levels) in <top (required)>'
# ./spec/bloombroom/hash/ffi_fnv_spec.rb:14:in `each'
# ./spec/bloombroom/hash/ffi_fnv_spec.rb:14:in `block (2 levels) in <top (required)>'
3) Bloombroom::FNVFFI should generate fnv1_64
Failure/Error: Bloombroom::FNVFFI.fnv1_64(k).should == v
expected: 17000360259377273861
got: 12371854390482265911 (using ==)
# ./spec/bloombroom/hash/ffi_fnv_spec.rb:21:in `block (3 levels) in <top (required)>'
# ./spec/bloombroom/hash/ffi_fnv_spec.rb:20:in `each'
# ./spec/bloombroom/hash/ffi_fnv_spec.rb:20:in `block (2 levels) in <top (required)>'
4) Bloombroom::FNVFFI should generate fnv1a_64
Failure/Error: Bloombroom::FNVFFI.fnv1a_64(k).should == v
expected: 10481507673508951749
got: 1936705574634818255 (using ==)
# ./spec/bloombroom/hash/ffi_fnv_spec.rb:27:in `block (3 levels) in <top (required)>'
# ./spec/bloombroom/hash/ffi_fnv_spec.rb:26:in `each'
# ./spec/bloombroom/hash/ffi_fnv_spec.rb:26:in `block (2 levels) in <top (required)>'
Deprecation Warnings:
Using `should` from rspec-expectations' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` with `config.expect_with(:rspec) { |c| c.syntax = :should }` instead. Called from /Users/korrigan/dev/quanta/bloombroom/spec/bloombroom/bits/bit_bucket_field_spec.rb:9:in `block (3 levels) in <top (required)>'.
If you need more of the backtrace for any of these deprecations to
identify where to make the necessary changes, you can configure
`config.raise_errors_for_deprecations!`, and it will turn the
deprecation warnings into errors, giving you the full backtrace.
1 deprecation warning total
Finished in 0.07627 seconds (files took 0.14334 seconds to load)
27 examples, 4 failures
Failed examples:
rspec ./spec/bloombroom/hash/ffi_fnv_spec.rb:7 # Bloombroom::FNVFFI should generate fnv1_32
rspec ./spec/bloombroom/hash/ffi_fnv_spec.rb:13 # Bloombroom::FNVFFI should generate fnv1a_32
rspec ./spec/bloombroom/hash/ffi_fnv_spec.rb:19 # Bloombroom::FNVFFI should generate fnv1_64
rspec ./spec/bloombroom/hash/ffi_fnv_spec.rb:25 # Bloombroom::FNVFFI should generate fnv1a_64