superlogin icon indicating copy to clipboard operation
superlogin copied to clipboard

New release?

Open silverbackvasco opened this issue 7 years ago • 13 comments

Any chance you could create a new release? The session file adapter and the couch-pwd dependency I find really useful updates if there aren't any major known issues currently with the master branch.

silverbackvasco avatar Feb 02 '18 19:02 silverbackvasco

Same question here... if not, has any alternative recomendation?

carromeu avatar Feb 02 '18 20:02 carromeu

Hi everyone... Sorry for the lack of activity on the project. I open source stuff I create for my own needs, but don't necessarily have the time to maintain everything.

I'm looking for help to maintain this project since it has become very popular.

Meanwhile, please help me triage the issues and existing PRs. Please list the most important bug fixes below and I will push a new release with updated deps.

Future releases will only support Node Active LTS 6+.

colinskow avatar Feb 02 '18 23:02 colinskow

6+ goes into maintenance this April https://github.com/nodejs/Release#release-schedule

will this affect updating a few of the dependencies? like with nodemailer, ( All versions below 4.0.1 are deprecated )?

MarcMcIntosh avatar Feb 07 '18 04:02 MarcMcIntosh

Node 4 maintenance is toast as of April, so I see no need to support. Too many dependencies now require 6+. Especially those written in ES6.

I'm willing to do a bugfix release and update all the deps, but I need somebody to triage the issues and PRs for me here and tell me exactly which updates are most important.

colinskow avatar Feb 07 '18 09:02 colinskow

what's a triage?

the package for couch-pwd is out-dated on npm, for what I can see in superlogin/lib/util.js hashPassword and verifyPassword are the only functions that use couch-pwd, with the later optionally setting the number of iterations for the hash to use. Should be easy enough to replace

MarcMcIntosh avatar Feb 13 '18 16:02 MarcMcIntosh

I personally think that the current master branch could be pushed as a release to allow some issues already addressed to be used without relying on a master branch that can change.

It'd be great to avoid couch-pwd as @MarcMcIntosh has suggested. Perhaps for now that's all that'd be needed to push a bug fix release version.

I respect your time and thank you so much for creating this package. Perhaps implementing rules about issues requiring users to add a replication of their issue would be the first step to ensure that the burden is taken off of you and more on the user demonstrating the bug. With that issues can be tagged and gone through one by one? Perhaps tags such as 'awaiting reproduction', 'confirmed bug', 'feature request', 'documentation' and 'help wanted'

silverbackdan avatar Feb 16 '18 12:02 silverbackdan

I've had a look through issues and PRs @colinskow - There are quite a few simple issues to clear off the list first. Perhaps in the PRs we can simply merge or reject the changes first:

  • https://github.com/colinskow/superlogin/pull/191 couch-pwd (is this how you want to address the couch-pwd deprecated library?)
  • https://github.com/colinskow/superlogin/pull/180 choice on whether you want random usernames generated - might be better to use a uuid library. I think it should be done on the application side though. It's more of a feature request.
  • https://github.com/colinskow/superlogin/pull/178 - could be merged IMO
  • https://github.com/colinskow/superlogin/pull/163 - this could be merged and would also close a ticket where you liked the idea
  • https://github.com/colinskow/superlogin/pull/160 - merge (docs)
  • https://github.com/colinskow/superlogin/pull/157 - merge (docs)
  • https://github.com/colinskow/superlogin/pull/147 - merge (docs)
  • https://github.com/colinskow/superlogin/pull/144 - could be merged
  • https://github.com/colinskow/superlogin/pull/136 - will take more time to review but would also close PR https://github.com/colinskow/superlogin/pull/95

I'll continue going through these when I get some more time if it helps.

silverbackdan avatar Feb 16 '18 13:02 silverbackdan

Are couch-pwd and pouchdb-auth similar...?

MarcMcIntosh avatar Feb 19 '18 18:02 MarcMcIntosh

Fork with updated deps and DDoc models: https://github.com/PhilLaFayette/superlogin

Let me know if you want me to do a pull-request.

EDIT: Let me mention that I haven't had time to sift-through those potential merges; though they're on the old 'to-do' list.

I think superlogin is great, because diversification of options. Everyone involved has been stellar, albeit a little more involved with other matters.

Anywhoo, I dig it, and I think Couch beats Mongo, (except for those few security exploits some script-kiddy got me with...) and I like seeing community effort towards authentication solutions.

Aztec03hub avatar Feb 28 '18 18:02 Aztec03hub

It would really be nice to get this working again in current versions of Node.

I can't see any alternative to pouchdb + superlogin if you are building something that needs strong capability to update while offline and sync with a database + are using social logins.

@colinskow Are you still around to accept any PRs or make a release?

@PhilLaFayette @silverbackdan Are you interested in maintaining the library?

Edit: Phil's fork seems to work so far. It would be great to merge it, though we'd need to swap couch-pwd out instead of using a git dep.

dantman avatar Feb 04 '19 05:02 dantman

I have created a repository https://github.com/hrustad1017/authServer that has a program that functions similarly to superlogin. Mine does not have all of the same features but it works well for me and I am open to adding more functionality and I would accept help if anybody is interested

hrustad1017 avatar Oct 20 '19 01:10 hrustad1017

I've made a simple PR (#209) to remove the couch-pwd dependency.

The PR passes all tests, but if someone else (@silverbackdan ? @dantman ?) can have a look at it and make any comments or improvements, it'd be helpful. That way, when @colinskow gets to it, he can hit "Merge PR" with confidence.

Colin, #209 fixes the highest priority issue with superlogin IMHO. It's the only thing stopping superlogin working right out of the box for most simple use-cases.

AdrianoFerrari avatar Jan 08 '20 01:01 AdrianoFerrari

This fork has been converted to typescript and seems pretty active: https://github.com/sl-nx/superlogin-next

dharmaturtle avatar Oct 10 '21 21:10 dharmaturtle