Colin Mollenhour comments

Results 344 comments of


                                            Colin Mollenhour

switch from del() to unklink() for redis >= 4.0

Hmm, I wonder if there is a potential issue with this since often times when keys are deleted they are just going to be repopulated again shortly after. That is,...

switch from del() to unklink() for redis >= 4.0

Running the commands on a single client may not be sufficient to prove the issue does not exist in a multi-client environment. Perhaps you'd like to submit a PR and...

Remove set instead of removing set members if only one tag

The `_notMatchingTags` flag is disabled by default so this code would not have any effect unless it is enabled by the user. When enabled it keeps track of all ids...

Database connection settings are cached and shared across Redis instances and Magento cluster backend nodes

I can see the merits of what you're trying to do but I've always approached it more at the system level. E.g. using a load balancer or a DNS address...

READONLY You can't write against a read only replica.

Thanks for the report, can you provide a fuller stack trace?

READONLY You can't write against a read only replica.

Are you both using the Magento patch or Magento LTS which has a fix for the config cache stampeding issue? Without this patch flushing the cache on a site with...

READONLY You can't write against a read only replica.

I didn't do a full diff, can you point out the difference more precisely? Here is the atomic ache update I was referring to: https://gist.github.com/colinmollenhour/2715268 I think n98-magerun also has...

READONLY You can't write against a read only replica.

Ahh, thanks. Inspecting the code I think that shouldn't be a material difference because the value is declared as false by default and if it is set to true that...

fwrite(): send of 8192 bytes failed with errno=104 Connection reset by peer

Yes, although the use of `array_chunk` will make the operation less atomic it seems that is preferable to errors and there is no better workaround that is simple that I...

fwrite(): send of 8192 bytes failed with errno=104 Connection reset by peer

Pushed a fix in 02eef64