hdfs
hdfs copied to clipboard
colinmarc
Transparent encryption
Hi @urykhy, thanks for the huge contribution!
I am interested in supporting this feature, but I lack the context to understand if the implementation is correct. If you're willing to put a bit more work in, I think we could get this merged.
To start with, I would feel better if we could add some more tests. The tests you added are a good start, but they are far from comprehensively testing this behavior. I wonder if it would make sense to run the entire test suite again (as another job on gh actions) with /_test marked as an encryption zone, rather than trying to duplicate tests here and there. We also need tests for the case where we don't have the key available, to make sure our error messages and exit statuses make sense.
We also need tests for the case where we don't have the key available, to make sure our error messages and exit statuses make sense.
test added.
