zod icon indicating copy to clipboard operation
zod copied to clipboard

[2888] fix emails with single quotes failing validation

Open Mansehej opened this issue 2 years ago • 4 comments

Fixes #2888

Mansehej avatar Oct 20 '23 11:10 Mansehej

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
Latest commit 656d6f589f975a4f428e9742db7ff4fad4ce9be1
Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/653261341227110008d32e40
Deploy Preview https://deploy-preview-2889--guileless-rolypoly-866f8a.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 20 '23 11:10 netlify[bot]

@colinhacks Any thoughts on merging this?

coreyward avatar Feb 26 '24 22:02 coreyward

Looks good. I copied this solution into my code that was failing on this problem, and it succeeded with your regex.

Thanks @kernwig. Any ideas on when we can expect this to be merged?

Mansehej avatar Mar 05 '24 18:03 Mansehej

No idea @Mansehej . I'm just a follow consumer of this library trying to bump this PR along so that the power(s) that be will notice it. :-)

kernwig avatar Mar 05 '24 21:03 kernwig

it'll be great for this to be merged 🙏 thanks for the good work!

LinHuiqing avatar Mar 14 '24 02:03 LinHuiqing

Thank you! Looking forward to this getting merged in

iamohcy avatar Mar 28 '24 07:03 iamohcy

Thanks, seems reasonable.

colinhacks avatar Apr 16 '24 22:04 colinhacks

This has landed in Zod 3.23.

https://github.com/colinhacks/zod/releases/tag/v3.23.0

colinhacks avatar Apr 21 '24 22:04 colinhacks