Colin McDonnell comments

Results 484 comments of


                                            Colin McDonnell

perf: lazy initialize ~standard schema property

Great idea. I appreciate you looking into the initialization perf. How are you benchmarking that? I'd like to have a decent benchmark for initialization if you have one - feel...

Required key inferred as optional in mutually recursive tree structure

Working perfectly with Zod 4 recursive object types! ```ts import * as z from "zod/v4"; function treeOf(baseSchema: TBaseSchema) { const AndNode = z.object({ type: z.literal("and"), get children() { return Tree.array();...

Union type generates anyOf instead oneOf

Discriminated union -> `oneOf` Union -> `anyOf` This is sound and mirrors the validation behavior of these keywords in JSON Schema. (With discriminated unions, the input can only match one...

feat: Add MAC Address validation (#3970)

@coderabbitai review this

Zod v4: Transform function loses type inference with generic functions and causes issues with implementAsync

I have not been able to fix this issue without also breaking Zod's recursive type inference. I'm quite confident there is a fundamental TypeScript limitation here.

The returned issue contains a field that is not described in errors.d.ts

So you're taking the error object and trying to assign to `$ZodIssueStringStartsWith`? There are several cases where Zod adds additional properties for additional context not described in the issue types,...

fix: incorrect nl localization for too_big and too_small

cc @hmnd is this ready to be merged?

fix: incorrect nl localization for too_big and too_small

cc @pullfrog review

zod v4.1.13 causes JavaScript heap out of memory

The repro from the linked issue was fixed, so this is a new issue that needs a new reproduction.

fix(implementasync): Inferred type should always be a promise

Thanks! Definitely an improvement.