Colin McDonnell

Results 428 comments of Colin McDonnell

Gotta love JavaScript. Thanks!

Thanks Igal! I like a lot of this but I made some changes. I consolidated `ZodBigIntTooSmallIssue` into `ZodTooSmallIssue` by converting `minimum: number` to `minimum: number | bigint`. I appreciate the...

> The use case I was thinking about was a 3rd party library, e.g. a database driver, returning `bigint` values, but zod consumer knows the underlying value should be in...

Thanks for the PR and cool concept, but I'm not sure about it. IMO it's not worth muddying the type definition of `ZodString` with a bunch of generics. It's a...

This fix has landed in `zod@beta`

Per https://github.com/colinhacks/zod/issues/2183#issuecomment-2016235363 I think this is generally a good idea. It's a breaking change though so this will land in Zod 4.

Unfortunately this is currently intentional. We need the `Partial` here because Zod doesn't do exhaustiveness checking across the values when you pass a `ZodEnum` as the key schema. in as...

There's clearly a lot of confusion about why ZodRecord is the way it is. The comment by @fwoelffel is exactly right: > Having partial records when the keys are a...

I appreciate the effort here, but I don't think something like this worth extending the already-very-long README.