Colin Maxfield

Results 38 comments of Colin Maxfield

@lukastaegert https://github.com/rollup/plugins/pull/1309

Github doesn't like it when you delete target branches for open PRs, it chokes and dies

@eoghanmurray that is all very fair hence why I said we weren't sure if opening this PR is really worth it and wanted to get your opinion. Ultimately we at...

Also "there isn't really a good reason or a sustainable way to do this in rrweb" is a totally reasonable final decision. This was a combination of me going through...

@eoghanmurray good idea. I have done that with other tools before just for some reason didn't think about trying that here. Probably was trying to be as surgical as possible...

For now thinking we will abandon this PR, it seems to most likely be addressed anyways by #1277 and so we can always revisit it after that one goes through

@eoghanmurray it has been awhile since we commented on this. This PR has been cut down to just address #874 , could we get another look here?

@Juice10 any chance you can take a look here as you had context on the original slack question?

@Juice10 anything that might need to be done here to get this minor change in?

@YunFeng0817 yeah I don't have access to the exact text but my first comment/description for the PR explain the same thing I explained in slack. In slack I just brought...