Colin Guthrie

Results 12 comments of Colin Guthrie

Thanks very much for your comments. I wasn't actually aware of Monkey Patching so this actually looks like a quite a good solution for my particular use case. If it...

@moy Yeah, I did get a few bits and bobs working here. The code in question is in the [Mageia](http://www.mageia.org/) [puppet git repo](http://gitweb.mageia.org/infrastructure/puppet/tree/deployment/mgagit/templates/git-post-receive-hook). This enhancement script parses the commit email...

Hi @dccarson, I'm afraid I never really bothered with HTML as such, so was happy with plain text emails. My hack was to add a list of links at the...

Oops missed a small bug in the mock test. Seems pull requests automatically update with the branch tho' so the extra couple commits I pushed today should fix that up!

> > Nevertheless it's worth fixing as we should respect the mentioned php.ini setting the application. > > This code doesnt do that > > The ini_get() function returns a...

> Commenting from the JSST side of things: I would not consider it as a security issue on it's own, as it requires that an authenticated session ID has been...

> > does anyone have any comment as to whether the code is needed at all? > > Yes, it makes sense! For the avoidance of doubt, I'm referring to...

> I have tested this item 🔴 unsuccessfully on [7b7f68d](https://github.com/joomla/joomla-cms/commit/7b7f68d873735cbae56634cefaaa60fc9dba8d0d) Can you clarify what you mean by unsuccessfully here? Were you able to reproduce the initial issue as per @carlitorweb...

Hi @brianteeman Do you have any further info about the failure case as requested above? I'm keen to get this updated for merging but need a little more info (see...

Hi all (especially @brianteeman). Just checking in to make sure these fixes are not lost. Can you give me more info and I can adapt accordingly and update to latest...